dongjoon-hyun commented on code in PR #2249:
URL: https://github.com/apache/orc/pull/2249#discussion_r2136880594
##########
.github/workflows/build_and_test.yml:
##########
@@ -248,3 +248,17 @@ jobs:
cmake .. -DBUILD_JAVA=OFF -DPROTOBUF_HOME=${CMAKE_PREFIX_PATH}
make package test-out
+ meson:
+ name: "Meson C++ configuration"
+ runs-on: ubuntu-latest
Review Comment:
1. To make it sure the supported OSes, please use OS matrix like the
existing system at least.
https://github.com/apache/orc/blob/63541a231b9c7317c755b675dd3ec10541735c0d/.github/workflows/build_and_test.yml#L62-L72
2. In addition to the above OSes, CI has the following test coverage too.
However, I believe (1) is enough for `Meson`.
https://github.com/apache/orc/blob/63541a231b9c7317c755b675dd3ec10541735c0d/.github/workflows/build_and_test.yml#L40-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
