wankunde commented on code in PR #2371:
URL: https://github.com/apache/orc/pull/2371#discussion_r2361940505
##########
java/core/src/test/org/apache/orc/TestVectorOrcFile.java:
##########
@@ -197,6 +197,7 @@ private static ByteBuffer byteBuf(int... items) {
@BeforeEach
public void openFileSystem(TestInfo testInfo) throws Exception {
+ conf.set("orc.stripe.size.checkRatio", "0");
Review Comment:
Because in these two UT files, some orc writers initialize with
`.stripeSize(100000)` and generate more stripes than before.
See https://github.com/apache/orc/actions/runs/17724428261/job/50362336226
```java
Error: Tests run: 10, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
1.282 s <<< FAILURE! -- in org.apache.orc.tools.TestFileDump
Error: org.apache.orc.tools.TestFileDump.testDictionaryThreshold -- Time
elapsed: 0.176 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <Column 0: count: 5000
hasNull: false> but was: <Column 0: count: 3000 hasNull: false>
at
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at
org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at org.apache.orc.tools.TestFileDump.checkOutput(TestFileDump.java:243)
at
org.apache.orc.tools.TestFileDump.testDictionaryThreshold(TestFileDump.java:443)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
Error: org.apache.orc.tools.TestFileDump.testHasNull -- Time elapsed: 0.029
s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
at org.apache.orc.tools.TestFileDump.testHasNull(TestFileDump.java:669)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
