cxzl25 commented on code in PR #2371:
URL: https://github.com/apache/orc/pull/2371#discussion_r2348926692
##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -118,6 +118,11 @@ public enum OrcConf {
"If the number of distinct keys in a dictionary is greater than this\n" +
"fraction of the total number of non-null rows, turn off \n" +
"dictionary encoding. Use 1 to always use dictionary encoding."),
+ DICTIONARY_MAX_SIZE_IN_BYTES("orc.dictionary.maxSizeInBytes",
+ "hive.exec.orc.dictionary.maxSizeInBytes",
+ 16 * 1024 * 1024,
Review Comment:
Look at the default dictionary of Presto and Trino, which is also 16mb.
https://github.com/prestodb/presto/blob/master/presto-orc/src/main/java/com/facebook/presto/orc/OrcWriterOptions.java#L37
```java
public static final DataSize DEFAULT_DICTIONARY_MAX_MEMORY = new
DataSize(16, MEGABYTE);
```
https://github.com/trinodb/trino/blob/master/lib/trino-orc/src/main/java/io/trino/orc/OrcWriterOptions.java#L52
```java
private static final DataSize DEFAULT_DICTIONARY_MAX_MEMORY =
DataSize.of(16, MEGABYTE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
