wgtmac commented on code in PR #2437:
URL: https://github.com/apache/orc/pull/2437#discussion_r2424438989
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -172,6 +172,12 @@ elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg")
list (APPEND ORC_SYSTEM_DEPENDENCIES Protobuf)
list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:protobuf::libprotobuf>")
set (PROTOBUF_EXECUTABLE protobuf::protoc)
+elseif (TARGET ${ARROW_PROTOBUF_LIBPROTOBUF})
+ # Used by Apache Arrow only, remove this once Arrow leverages FetchContent
for Protobuf
+ add_library (orc_protobuf INTERFACE IMPORTED)
+ target_link_libraries(orc_protobuf INTERFACE ${ARROW_PROTOBUF_LIBPROTOBUF})
+ set (PROTOBUF_EXECUTABLE ${ARROW_PROTOBUF_PROTOC})
+ message(STATUS "Using existing ${ARROW_PROTOBUF_LIBPROTOBUF}")
Review Comment:
As I have successfully migrated dependencies in the Apache ORC to use
`FetchContent` with `FIND_PACKAGE_ARGS`, I think `Snappy` and `Zstandard`
should be pretty easy to migrate. It is a little bit tricky for `Protobuf` to
find `protoc`. `ZLIB` is more messy since it does not have a release with good
CMake support so I am currently using an unreleased git tag. I can work on this
in the Apache Arrow one by one but may need your help :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
