kou commented on code in PR #2437:
URL: https://github.com/apache/orc/pull/2437#discussion_r2424157728
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -172,6 +172,12 @@ elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg")
list (APPEND ORC_SYSTEM_DEPENDENCIES Protobuf)
list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:protobuf::libprotobuf>")
set (PROTOBUF_EXECUTABLE protobuf::protoc)
+elseif (TARGET ${ARROW_PROTOBUF_LIBPROTOBUF})
+ # Used by Apache Arrow only, remove this once Arrow leverages FetchContent
for Protobuf
+ add_library (orc_protobuf INTERFACE IMPORTED)
+ target_link_libraries(orc_protobuf INTERFACE ${ARROW_PROTOBUF_LIBPROTOBUF})
+ set (PROTOBUF_EXECUTABLE ${ARROW_PROTOBUF_PROTOC})
+ message(STATUS "Using existing ${ARROW_PROTOBUF_LIBPROTOBUF}")
Review Comment:
Ah, I haven't used `FetchContent_Declare(FIND_PACKAGE_ARGS)` yet. Sorry.
If Apache Arrow migrates Protobuf, Snappy, zlib and Zstandard to
FetchContent, we don't need this in Apache ORC, right? If so, let's improve
Apache Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
