bharatviswa504 commented on a change in pull request #1498:
URL: https://github.com/apache/ozone/pull/1498#discussion_r514821040
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/AWSSignatureProcessor.java
##########
@@ -167,7 +174,9 @@ public void parse() throws Exception {
}
@VisibleForTesting
- public String buildCanonicalRequest() throws OS3Exception {
+ protected String buildCanonicalRequest() throws OS3Exception {
+ Preconditions.checkNotNull(v4Header);
Review comment:
Minor NIT: do we still need this precondition check.
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
