avijayanhwx commented on a change in pull request #1692:
URL: https://github.com/apache/ozone/pull/1692#discussion_r542564473
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -1091,6 +1094,23 @@ message PrepareResponse {
required uint64 txnID = 1;
}
+message PrepareStatusRequest {
+ required uint64 txnID = 1;
+}
+
+message PrepareStatusResponse {
+ enum PrepareStatus {
+ // TODO
+ // HDDS-4569 may introduce new states here, like marker file found
+ // but with different txn id. We can add them as make sense.
+ PREPARE_NOT_STARTED = 1;
+ PREPARE_IN_PROGRESS = 2;
+ PREPARE_COMPLETED = 3;
+ }
+ required PrepareStatus status = 1;
+ optional uint64 currentTxnIndex = 2;
Review comment:
@errose28 Yes, I agree. Since I expect some changes in the status enum
fields as well as the logic in OzoneManagerRequestHandler#getPrepareStatus
(usage of marker file vs OM transaction info), I believe we can punt the
documentation to a follow up patch after HDDS-4569. That is the reason I have
not added an integration test as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
