smengcl commented on a change in pull request #1353:
URL: https://github.com/apache/ozone/pull/1353#discussion_r573926695
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -333,7 +332,7 @@ public StorageContainerManager(OzoneConfiguration conf,
eventQueue);
blockProtocolServer = new SCMBlockProtocolServer(conf, this);
clientProtocolServer = new SCMClientProtocolServer(conf, this);
- httpServer = new StorageContainerManagerHttpServer(conf);
+ httpServer = new StorageContainerManagerHttpServer(conf, this);
Review comment:
Hi Xiaoyu, thanks for the comment. I get the point that we should avoid
passing half inited objects to other constructors. But I didn't quite get this:
> Based on the servlet code, we can minimize the dependency with just
MetaStore and the DBCheckPointMetrics here, and set/get them into/from the
webAppContext.
Could you elaborate a bit on this? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
