smengcl commented on a change in pull request #1353:
URL: https://github.com/apache/ozone/pull/1353#discussion_r579045162
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -333,7 +332,7 @@ public StorageContainerManager(OzoneConfiguration conf,
eventQueue);
blockProtocolServer = new SCMBlockProtocolServer(conf, this);
clientProtocolServer = new SCMClientProtocolServer(conf, this);
- httpServer = new StorageContainerManagerHttpServer(conf);
+ httpServer = new StorageContainerManagerHttpServer(conf, this);
Review comment:
@xiaoyuyao I decided to move `httpServer = new
StorageContainerManagerHttpServer(conf, this);` from SCM constructor to
`start()` -- the same approach as we already do for OM:
https://github.com/apache/ozone/blob/d964cc98adeaa42d6e6ac34f4fcc591171ee7ff3/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L1187
This should avoid the race condition. Pls take a look when you are
available. :)
I have tested locally that http://127.0.0.1:9876/dbCheckpoint downloads the
SCM DB archive for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
