slfan1989 commented on PR #7482: URL: https://github.com/apache/ozone/pull/7482#issuecomment-2513496454
> @slfan1989 Thanks for the patch. LGTM +1. > > One question, since [HDDS-11462](https://issues.apache.org/jira/browse/HDDS-11462) #7206) updated the `overview.html` template to get the host name, before this patch, the OM and SCM overview html only have empty hostname? @ivandika3 Thank you very much for reviewing this PR! Before this PR, OM and SCM did not display the hostname information, which was consistent with the previous behavior. We have added a check to ensure that the related information is only displayed if the `hostName` exists. https://github.com/apache/ozone/blob/69538b0b85f495f0a51c120b379f052a3c838e14/hadoop-hdds/framework/src/main/resources/webapps/static/templates/overview.html#L17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
