dombizita commented on code in PR #7715:
URL: https://github.com/apache/ozone/pull/7715#discussion_r1923997301
##########
hadoop-ozone/dev-support/checks/kubernetes.sh:
##########
@@ -19,19 +19,37 @@ set -u -o pipefail
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-: ${KUBECONFIG:=/etc/rancher/k3s/k3s.yaml}
-
Review Comment:
Moving this to the
[k3s.sh](https://github.com/apache/ozone/pull/7715/files#diff-24c78ccc28da19513e591d1c75b564abb8ca3ba9a2994978608254eeb7fc5730)
file, won't cause problems if later in the if condition we won't call the
script? I'm not too familiar with this, I'm just brining it up because it's a
small behaviour change. The `export KUBECONFIG` is still called at the same
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
