adoroszlai commented on code in PR #7715:
URL: https://github.com/apache/ozone/pull/7715#discussion_r1924044545
##########
hadoop-ozone/dev-support/checks/kubernetes.sh:
##########
@@ -19,19 +19,37 @@ set -u -o pipefail
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-: ${KUBECONFIG:=/etc/rancher/k3s/k3s.yaml}
-
Review Comment:
The definition is moved because this value of `KUBECONFIG` is specific to
K3S. If another Kubernetes environment is to be used, we still need
`$KUBECONFIG` to be exported for subprocesses, but the value is coming from
external source (user-defined).
##########
hadoop-ozone/dev-support/checks/kubernetes.sh:
##########
@@ -19,19 +19,37 @@ set -u -o pipefail
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-: ${KUBECONFIG:=/etc/rancher/k3s/k3s.yaml}
-
Review Comment:
The definition is moved because this value of `$KUBECONFIG` is specific to
K3S. If another Kubernetes environment is to be used, we still need
`KUBECONFIG` to be exported for subprocesses, but the value is coming from
external source (user-defined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
