jojochuang commented on code in PR #7778:
URL: https://github.com/apache/ozone/pull/7778#discussion_r1942052873
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4289,8 +4249,9 @@ public void checkLeaderStatus() throws
OMNotLeaderException,
/**
* Return if Ratis is enabled or not.
*/
+ // FIXME remove
Review Comment:
TODO
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java:
##########
@@ -260,9 +254,6 @@ public OMPrefixAclOpResult addAcl(OzoneObj ozoneObj,
OzoneAcl ozoneAcl,
// update the in-memory prefix tree
prefixTree.insert(ozoneObj.getPath(), prefixInfo);
- if (!isRatisEnabled) {
Review Comment:
I'm not sure about this one. This code path (isRatisEnabled=false) is used
by OmSnapshotManager. Are we sure it doesn't break the Snapshot feature?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -384,8 +384,7 @@ public OmSnapshot load(@Nonnull UUID snapshotId) throws
IOException {
try {
// create the other manager instances based on snapshot
// metadataManager
- PrefixManagerImpl pm = new PrefixManagerImpl(ozoneManager,
snapshotMetadataManager,
- false);
Review Comment:
isRatisEnabled = false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
