jojochuang commented on code in PR #7778:
URL: https://github.com/apache/ozone/pull/7778#discussion_r1943486067
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -79,7 +71,6 @@ public class OzoneManagerProtocolServerSideTranslatorPB
implements OzoneManagerP
* Only used to handle write requests when ratis is disabled.
* When ratis is enabled, write requests are handled by the state machine.
*/
Review Comment:
Remove this comment
```suggestion
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java:
##########
@@ -64,13 +64,7 @@ public class PrefixManagerImpl implements PrefixManager {
// In-memory prefix tree to optimize ACL evaluation
private RadixTree<OmPrefixInfo> prefixTree;
- // TODO: This isRatisEnabled check will be removed as part of HDDS-1909,
- // where we integrate both HA and Non-HA code.
- private boolean isRatisEnabled;
-
- public PrefixManagerImpl(OzoneManager ozoneManager, OMMetadataManager
metadataManager,
- boolean isRatisEnabled) {
- this.isRatisEnabled = isRatisEnabled;
+ public PrefixManagerImpl(OzoneManager ozoneManager, OMMetadataManager
metadataManager) {
Review Comment:
OzoneManager instantiates a PrefixManagerImpl with isRatisEnabled = true and
OmSnapshotManager instantiates a PrefixManagerImpl with isRatisEnabled =
false.
I would suggest to restore PrefixManagerImpl, and rename isRatisEnabled to
persistentToRocksDB, because it looks like OmSnapshotManager repurposed it and
which is unrelated to Ratis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
