adoroszlai commented on code in PR #8062:
URL: https://github.com/apache/ozone/pull/8062#discussion_r1992855187


##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -72,3 +72,63 @@ create_aws_dir() {
     popd
   fi
 }
+
+
+# Function to find project paths for a given test class
+# Returns an array of project paths in PROJECT_PATHS
+find_project_paths_for_test_class() {

Review Comment:
   Changes in `_lib.sh` trigger full CI run.  I would prefer to add this 
function as a helper script in `dev-support/ci`, and add exclusions in 
`dev-support/ci/selective_ci_checks.sh`, similar to `pr_title_check`.



##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -72,3 +72,63 @@ create_aws_dir() {
     popd
   fi
 }
+
+
+# Function to find project paths for a given test class
+# Returns an array of project paths in PROJECT_PATHS
+find_project_paths_for_test_class() {
+  local test_class="$1"
+  # Reset the global PROJECT_PATHS array
+  PROJECT_PATHS=()

Review Comment:
   I would change the script to print results to stdout and debug messages to 
stderr, instead of using a global variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to