Galsza commented on code in PR #8173:
URL: https://github.com/apache/ozone/pull/8173#discussion_r2023648531
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/db/DatanodeDBProfile.java:
##########
@@ -115,34 +114,28 @@ private StorageBasedProfile(DBProfile profile) {
baseProfile = profile;
}
- private ManagedDBOptions getDBOptions() {
- return baseProfile.getDBOptions();
+ private ManagedDBOptions getDBOptions(Path dbPath) {
+ return baseProfile.getDBOptions(dbPath);
}
private ManagedColumnFamilyOptions getColumnFamilyOptions(
- ConfigurationSource config) {
+ ConfigurationSource config, Path pathToDb, String cfName) {
final MemoizedSupplier<ManagedColumnFamilyOptions> supplier =
- MemoizedSupplier.valueOf(() -> createColumnFamilyOptions(config));
+ MemoizedSupplier.valueOf(() -> {
+ ManagedColumnFamilyOptions options =
+ baseProfile.getColumnFamilyOptions(pathToDb, cfName);
+ options.setReused(true);
+ return options.closeAndSetTableFormatConfig(
+ getBlockBasedTableConfig(pathToDb, cfName, config));
+ });
Review Comment:
Thanks for the suggestion it's indeed clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
