Galsza commented on code in PR #8173:
URL: https://github.com/apache/ozone/pull/8173#discussion_r2023663820
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java:
##########
@@ -142,10 +134,6 @@ private DBStoreBuilder(ConfigurationSource configuration,
this.rocksDbStat = configuration.getTrimmed(
OZONE_METADATA_STORE_ROCKSDB_STATISTICS,
OZONE_METADATA_STORE_ROCKSDB_STATISTICS_DEFAULT);
- this.rocksDbCfWriteBufferSize = (long) configuration.getStorageSize(
Review Comment:
Most other configs are few enough that they are hardcoded programatically
into Ozone, I'm not sure we want to change that here for the default ini.
However having an example ini would be more failsafe when the user gets control.
I'm not sure how the default ini should be handled for example in test
environments. If we rely on the default ini being always there then I'm not
sure how to simply do it for all test environments. Do you have a
recommendation? In the case we have to modify most docker-yaml files I'd prefer
to defer that change to a separate Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
