sodonnel commented on a change in pull request #2096:
URL: https://github.com/apache/ozone/pull/2096#discussion_r611549627



##########
File path: 
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java
##########
@@ -158,15 +158,6 @@ private ScmContainerLocationResponse submitRpcRequest(
     return response;
   }
 
-  /**
-   * Asks SCM where a container should be allocated. SCM responds with the set
-   * of datanodes that should be used creating this container. Ozone/SCM only
-   * supports replication factor of either 1 or 3.
-   *
-   * @param type   - Replication Type
-   * @param factor - Replication Count
-   */
-  @Override
   public ContainerWithPipeline allocateContainer(

Review comment:
       Just double checking - is this change intentional? I have not looked 
into the details of this class etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to