sodonnel commented on a change in pull request #2096:
URL: https://github.com/apache/ozone/pull/2096#discussion_r611551806
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocol/ScmBlockLocationProtocol.java
##########
@@ -59,8 +60,29 @@
* @return allocated block accessing info (key, pipeline).
* @throws IOException
*/
- List<AllocatedBlock> allocateBlock(long size, int numBlocks,
+ @Deprecated
+ default List<AllocatedBlock> allocateBlock(long size, int numBlocks,
ReplicationType type, ReplicationFactor factor, String owner,
+ ExcludeList excludeList) throws IOException {
+ return allocateBlock(size, numBlocks, ReplicationConfig
+ .fromTypeAndFactor(type, factor), owner, excludeList);
+ }
+
+ /**
+ * Asks SCM where a block should be allocated. SCM responds with the
+ * set of datanodes that should be used creating this block.
+ *
+ * @param size - size of the block.
+ * @param numBlocks - number of blocks.
+ * @param replicationConfig - replicationConfiguration
+ * @param excludeList List of datanodes/containers to exclude during
Review comment:
Nit: Add owner to param spec - note it was missing before these changes,
so not caused by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
