ChenSammi commented on code in PR #8286: URL: https://github.com/apache/ozone/pull/8286#discussion_r2046305621
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerDeadNodeHandler.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.node; + +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.server.events.EventHandler; +import org.apache.hadoop.hdds.server.events.EventPublisher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Updates the DiskBalancer status of a datanode to UNKNOWN when the datanode is marked dead. + * + * This handler listens for DEAD_NODE events and ensures that DiskBalancer + * does not retain outdated state for unreachable datanodes. + */ + +public class DiskBalancerDeadNodeHandler implements EventHandler<DatanodeDetails> { + + private static final Logger LOG = LoggerFactory.getLogger(DiskBalancerDeadNodeHandler.class); + private final DiskBalancerManager diskBalancerManager; + + public DiskBalancerDeadNodeHandler(DiskBalancerManager diskBalancerManager) { + this.diskBalancerManager = diskBalancerManager; + } + + @Override + public void onMessage(DatanodeDetails datanodeDetails, EventPublisher publisher) { Review Comment: Yeah, please reuse DeadNodeHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
