kerneltime commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2061406072
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -292,6 +294,14 @@ public Response get(
return Response.ok(response).build();
}
+ private int validateMaxKeys(int maxKeys) throws OS3Exception {
+ if (maxKeys <= 0) {
+ throw S3ErrorTable.newError(S3ErrorTable.INVALID_ARGUMENT, "maxKeys must
be > 0");
+ }
+
+ return Math.min(maxKeys, 1000);
Review Comment:
I agree that AWS has a limit it enforces. For Ozone, we should set the
default to 1000, but in some high-performance use cases, it might make sense to
have it higher as well, where the listing needs to be completed in one round
trip. If we make it configurable, the customer will have a choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
