peterxcli commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2078927012


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -521,6 +521,28 @@ public void testEncodingTypeException() throws IOException 
{
     assertEquals(S3ErrorTable.INVALID_ARGUMENT.getCode(), e.getCode());
   }
 
+  @Test

Review Comment:
   Should add another test case to check if the `max-keys` would be set to the 
max-key num defined in config. This can be verified by creating 1000+ key and 
list bucket with 1000+ max-key param, then check if the response key num is 
1000. 
   (If we allow the config to be set to lower value then it would be better to 
set a low value for it, but it depends on 
https://github.com/apache/ozone/pull/8307#discussion_r2078923790)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to