kerneltime commented on code in PR #8388: URL: https://github.com/apache/ozone/pull/8388#discussion_r2074703642
########## hadoop-hdds/docs/content/design/dn-min-space-configuration.md: ########## @@ -0,0 +1,106 @@ +--- +title: Minimum free space configuration for datanode volumes +summary: Describe proposal for minimum free space configuration which volume must have to function correctly. +date: 2025-05-5 +jira: HDDS-12928 +status: draft +author: Sumit Agrawal +--- +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> + +# Abstract +Volume in datanode stores the container data and metadata of this is present in volume db. +There are various parallel operation going on such as import container, export container, write and delete data blocks, Review Comment: Also, rebuilds of EC containers might also be on going. I like @krishnaasawa1's suggestion of bringing in the container size into the calculation. Maybe `max(min disk space, configured spare container multiple*size per container)`. The default container multiple being 4 (20 gigs) ########## hadoop-hdds/docs/content/design/dn-min-space-configuration.md: ########## @@ -0,0 +1,106 @@ +--- +title: Minimum free space configuration for datanode volumes +summary: Describe proposal for minimum free space configuration which volume must have to function correctly. +date: 2025-05-5 +jira: HDDS-12928 +status: draft +author: Sumit Agrawal +--- +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> + +# Abstract +Volume in datanode stores the container data and metadata of this is present in volume db. Review Comment: ```suggestion Volume in the datanode stores the container data and metadata (rocks db co-located on the volume) ``` ########## hadoop-hdds/docs/content/design/dn-min-space-configuration.md: ########## @@ -0,0 +1,106 @@ +--- +title: Minimum free space configuration for datanode volumes +summary: Describe proposal for minimum free space configuration which volume must have to function correctly. +date: 2025-05-5 +jira: HDDS-12928 +status: draft +author: Sumit Agrawal +--- +<!-- + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. See accompanying LICENSE file. +--> + +# Abstract +Volume in datanode stores the container data and metadata of this is present in volume db. +There are various parallel operation going on such as import container, export container, write and delete data blocks, +create and delete containers. The space is also required for volume db to perform compaction at regular interval. +This is hard to capture exact usages and free available space. So, this is required to configure minimum free space Review Comment: ```suggestion container repairs, create and delete containers. The space is also required for volume db to perform compaction at regular interval. This is hard to capture exact usages and free available space. So, this is required to configure minimum free space ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
