sumitagrawl commented on code in PR #8388:
URL: https://github.com/apache/ozone/pull/8388#discussion_r2084241283
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestDatanodeConfiguration.java:
##########
@@ -29,6 +29,7 @@
import static
org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration.FAILED_DB_VOLUMES_TOLERATED_KEY;
import static
org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration.FAILED_METADATA_VOLUMES_TOLERATED_KEY;
import static
org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration.FAILED_VOLUMES_TOLERATED_DEFAULT;
+import static
org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration.HDDS_DATANODE_VOLUME_MIN_FREE_SPACE_PERCENT_DEFAULT;
Review Comment:
unset is done for ozone-site.xml as defined in test module, so that it can
use default value if not defined. comment added.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -280,10 +280,9 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
" When the difference between volume capacity and used reaches this
number," +
" containers that reside on this volume will be closed and no new
containers" +
" would be allocated on this volume." +
- " Either of min.free.space or min.free.space.percent should be
configured, when both are set then" +
- " min.free.space will be used."
+ " Max of min.free.space and min.free.space.percent will be
configured when both are set."
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
