swamirishi commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2094698239
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java:
##########
@@ -150,5 +181,21 @@ public final void removeFromDB() throws IOException {
@Override
public void close() {
rocksDBIterator.close();
+ closed = true;
+ releaseEntry();
+ }
+
+ public static final class AutoCloseableRawKeyValue<RAW> extends
RawKeyValue<RAW> implements AutoCloseable {
+ private final UncheckedAutoCloseableSupplier<RawKeyValue<RAW>> keyValue;
+
+ private AutoCloseableRawKeyValue(ReferenceCountedObject<RawKeyValue<RAW>>
kv) {
Review Comment:
No we should only return the autoCloseable value and not the reference
counted object itself if that is what you mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
