swamirishi commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2094701065
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java:
##########
@@ -125,23 +151,28 @@ public final void seekToLast() {
} else {
throw new UnsupportedOperationException("seekToLast: prefix != null");
}
- setCurrentEntry();
+ releaseEntry();
}
@Override
- public final Table.KeyValue<RAW, RAW> seek(RAW key) {
+ public final AutoCloseableRawKeyValue<RAW> seek(RAW key) {
seek0(key);
+ releaseEntry();
setCurrentEntry();
- return currentEntry;
+ // Current entry should be only closed when the next() and thus closing
the returned entry should be a noop.
+ if (hasNext()) {
+ return new AutoCloseableRawKeyValue<>(currentEntry);
+ }
+ return null;
}
@Override
public final void removeFromDB() throws IOException {
if (rocksDBTable == null) {
throw new UnsupportedOperationException("remove");
}
- if (currentEntry != null) {
- delete(currentEntry.getKey());
+ if (previousKeyValue != null) {
+ delete(previousKeyValue.getKey());
Review Comment:
RemoveFromDB should not be called after release. That is the whole point of
returning a CloseableValue. Even getKey() and getValue() won't be valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
