Copilot commented on code in PR #8502:
URL: https://github.com/apache/ozone/pull/8502#discussion_r2103417080
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1587,6 +1587,15 @@ private void initializeRatisDirs(OzoneConfiguration
conf) throws IOException {
omRatisSnapshotDir = OmUtils.createOMDir(
OzoneManagerRatisUtils.getOMRatisSnapshotDirectory(conf));
+ File omRatisDir = new File(omRatisDirectory);
+ // omMetaDir and omRatisDirectory must be under the same mount point for
hard links to work properly
+ if (!OmUtils.isUnderSameMountPoint(omMetaDir, omRatisSnapshotDir)) {
Review Comment:
The mount point check compares 'omMetaDir' with 'omRatisSnapshotDir', but
the error message mentions ozone.metadata.dirs and ozone.om.db.dirs. Please
verify that the correct directories are being compared; if the intent is to
ensure the metadata and DB directories are on the same mount point, consider
replacing 'omRatisSnapshotDir' with the appropriate variable.
```suggestion
// omMetaDir and omDbDir must be under the same mount point for hard
links to work properly
if (!OmUtils.isUnderSameMountPoint(omMetaDir, omDbDir)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
