smengcl commented on PR #8502: URL: https://github.com/apache/ozone/pull/8502#issuecomment-2936368876
> @smengcl I really don't think this should be handled in this way. What are your thoughts on the [comment](https://issues.apache.org/jira/browse/HDDS-13062?focusedCommentId=17952715&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17952715) I left on the jira? > > > Directory configs are really only useful if you have the option to split them across devices. If two locations need to be on the same drive for correctness, Ozone can handle this automatically using its own directory layout. This is why the tmp directory used for container import/export on datanodes (which is somewhat analogous to snapshot install on OM) is not configurable. > > > The easiest thing to do from a config management perspective is to use a fixed directory within ozone.om.db.dirs to import the snapshot, deprecate ozone.om.ratis.snapshot.dir and leave ozone.metadata.dirs untouched. This reduces the number of configurations and restrictions while making the system do the correct thing out of the box. It also makes space management specifications easier because we can say that ozone.om.db.dirs needs 2x space to handle snapshot install, instead of figuring out how to specify this for ozone.metadata.dirs and ozone.om.db.dirs which would be basically the same location. Hey @errose28 , I was thinking of just patching this first by blocking invalid configs and then play with the configs as a next step. But now it seems it might be easier to just do the config changes directly. Need to dig a bit more to figure out a way to change those configs without breaking compatibility / provide guidance during upgrades. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
