Tejaskriya commented on code in PR #8520: URL: https://github.com/apache/ozone/pull/8520#discussion_r2192103030
########## hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/datanode/TestListInfoSubcommand.java: ########## Review Comment: The 2 tests added are very similar, just a difference of < or >. Can we try using parameterized test with the 2 parameters and combine the tests into 1? If the above doesn't seem feasible, then the setup and other common code could be extracted out to a different method which can be used in both the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
