ChenSammi commented on code in PR #8845:
URL: https://github.com/apache/ozone/pull/8845#discussion_r2227093341
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -368,6 +368,8 @@ message DeletedBlocksTransaction {
repeated int64 localID = 3;
// the retry time of sending deleting command to datanode.
required int32 count = 4;
+ optional uint64 totalBlockSize = 5;
+ optional uint64 totalBlockReplicatedSize = 6;
Review Comment:
Deriving the replicated size from container info is considered at the
beginning. But there is chance that container is temporarily not available in
some corner cases in SCM, which need to be handled. As OM has both the size and
replicated size handy, so persist both size and replicated size in tx, can save
the complexity of logic to handle container not available case, make the logic
simple and robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]