ChenSammi commented on code in PR #8845:
URL: https://github.com/apache/ozone/pull/8845#discussion_r2227153767
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/ScmBlockDeletingServiceMetrics.java:
##########
@@ -100,15 +102,38 @@ public final class ScmBlockDeletingServiceMetrics
implements MetricsSource {
private final Map<DatanodeID, DatanodeCommandDetails> numCommandsDatanode =
new ConcurrentHashMap<>();
- private ScmBlockDeletingServiceMetrics() {
+ @Metric(about = "The number of transactions whose totalBlockSize is fetched
from in memory cache")
+ private MutableGaugeLong numBlockDeletionTransactionSizeFromCache;
+
+ @Metric(about = "The number of transactions whose totalBlockSize is fetched
from DB")
+ private MutableGaugeLong numBlockDeletionTransactionSizeFromDB;
+
+ private static final MetricsInfo NUM_BLOCK_DELETION_TRANSACTION =
Interns.info(
+ "numBlockDeletionTransaction",
+ "The number of transactions in DB.");
+
+ private static final MetricsInfo NUM_BLOCK_IN_DELETION_TRANSACTION =
Interns.info(
+ "numBlockOfDeletionTransaction",
+ "The number of blocks in all transactions in DB.");
Review Comment:
Make sense, more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]