SaketaChalamchala commented on code in PR #8899:
URL: https://github.com/apache/ozone/pull/8899#discussion_r2258544101


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -297,6 +297,16 @@ private void transferSnapshotData(Set<String> 
sstFilesToExclude, Path tmpdir, Se
         
om.getOmSnapshotManager().invalidateCacheEntry(UUID.fromString(snapshotId));
         writeDBToArchive(sstFilesToExclude, snapshotDir, maxTotalSstSize, 
archiveOutputStream, tmpdir,
             hardLinkFileMap, false);
+        Path snapshotDirParent = snapshotDir.getParent();
+        if (snapshotDirParent != null) {
+          Path snapshotLocalPropertyYaml = snapshotDirParent.resolve(
+              snapshotDir.getFileName() + ".yaml");

Review Comment:
   Could you reuse `OmSnapshotManager.getSnapshotLocalPropertyYamlPath()` here? 
That way, any potential changes to the yaml file path will be reflected here 
without modifying the path in multiple places. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to