sarvekshayr commented on code in PR #8941:
URL: https://github.com/apache/ozone/pull/8941#discussion_r2276008690
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
@@ -148,6 +155,11 @@ void processKey(OzoneClient ozoneClient, String
volumeName, String bucketName, S
OmKeyInfo keyInfo = ozoneClient.getProxy().getKeyInfo(
volumeName, bucketName, keyName, false);
+ // Check if key should be filtered based on replication config
+ if (shouldFilterKey(keyInfo)) {
Review Comment:
+1 on renaming the method.
Since we already have a `processKey()` method, it would be better to make
this name more specific to what’s being filtered. Something like
`shouldProcessKeyByReplicationType()` would indicate that it checks whether a
key should be processed based on its replication type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
