sumitagrawl commented on code in PR #8932:
URL: https://github.com/apache/ozone/pull/8932#discussion_r2287865688


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java:
##########
@@ -196,6 +196,9 @@ public final class OzoneConsts {
    */
   public static final String OZONE_SCM_DATANODE_ID_FILE_DEFAULT = 
"datanode.id";
 
+  public static final String

Review Comment:
   instead of keeping status in local file, it can be put in common DB in DN.



##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java:
##########
@@ -115,6 +123,8 @@ public class StateContext {
   private final AtomicReference<Message> containerReports;
   private final AtomicReference<Message> nodeReport;
   private final AtomicReference<Message> pipelineReports;
+  private final AtomicReference<Message> crlStatusReport;

Review Comment:
   Unable to identify how CRLStatusReport is related to DiskBalancer, plz 
remove if not related



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to