Gargi-jais11 commented on code in PR #8915:
URL: https://github.com/apache/ozone/pull/8915#discussion_r2320759050
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/DownloadAndImportReplicator.java:
##########
@@ -71,9 +71,20 @@ public void replicate(ReplicationTask task) {
LOG.info("Starting replication of container {} from {} using {}",
containerID, sourceDatanodes, compression);
HddsVolume targetVolume = null;
+
+ // Use replicate size from command if available, otherwise use default
+ long spaceReserved = 0;
+ Long replicateSize = task.getReplicateSize();
+ if (replicateSize != null) {
Review Comment:
If `replicateSize = 0 ` means that an empty container is sent for
replication . So is it possible that empty containers will be created?
The current code should handle this correctly because:
`containerImporter.getRequiredReplicationSpace(0)` should account for
minimum container overhead (metadata, structure files, etc.).
Are you concerned about insufficient space allocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
