Gargi-jais11 commented on code in PR #8915:
URL: https://github.com/apache/ozone/pull/8915#discussion_r2320766924
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECMisReplicationHandler.java:
##########
@@ -83,6 +83,7 @@ protected int sendReplicateCommands(
// For EC containers, we need to track the replica index which is
// to be replicated, so add it to the command.
cmd.setReplicaIndex(replica.getReplicaIndex());
+ cmd.setReplicateSize(containerInfo.getUsedBytes());
Review Comment:
You're right about consistency - this ensures the protobuf message has
complete information regardless of container type, which makes the replication
pipeline more uniform.
Without this change, EC container replication would work, but might reserve
incorrect amounts of space falling back to defaultContainerSize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
