siddhantsangwan commented on PR #8915: URL: https://github.com/apache/ozone/pull/8915#issuecomment-3319113406
> I have provided the analysis of both approaches above. I prefer using first approach as it is adding container size is simple with single additional dependency (ContainerController). Both approaches need to add containerSize through GrpcContainerUploader by passing it to SendContainerOutputStream, so I believe first approach will be better to add ContainerController instance to this class, rather than passing via ReplicateContainerCommandHandler. Please have a look and correct me if I am wrong anywhere. I agree, based on this we can go ahead with the first approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
