Copilot commented on code in PR #9118:
URL: https://github.com/apache/ozone/pull/9118#discussion_r2415010597
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaOp.java:
##########
@@ -32,18 +34,16 @@ public class ContainerReplicaOp {
private final long deadlineEpochMillis;
private final long containerSize;
- public static ContainerReplicaOp create(PendingOpType opType,
- DatanodeDetails target, int replicaIndex) {
- return new ContainerReplicaOp(opType, target, replicaIndex, null,
- System.currentTimeMillis(), 0);
- }
-
- public ContainerReplicaOp(PendingOpType opType,
- DatanodeDetails target, int replicaIndex, SCMCommand<?> command,
- long deadlineEpochMillis) {
- this(opType, target, replicaIndex, command, deadlineEpochMillis, 0);
- }
-
+ /**
+ * Create a ContainerReplicaOp with all parameters.
+ *
+ * @param opType type of operation
+ * @param target target datanode
+ * @param replicaIndex replica index (0 for Ratis; > 0 for EC)
Review Comment:
The HTML entity '>' should be '>' in the Javadoc comment for better
readability.
```suggestion
* @param replicaIndex replica index (0 for Ratis; > 0 for EC)
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaPendingOps.java:
##########
@@ -64,14 +64,17 @@ public class ContainerReplicaPendingOps {
private final ConcurrentHashMap<DatanodeID, SizeAndTime>
containerSizeScheduled = new ConcurrentHashMap<>();
private ReplicationManager.ReplicationManagerConfiguration rmConf;
- public ContainerReplicaPendingOps(Clock clock) {
- this.clock = clock;
- resetCounters();
- }
-
+ /**
+ * Creates a ContainerReplicaPendingOps with all parameters.
+ * This is the single constructor that should be used for all cases.
+ *
Review Comment:
[nitpick] There's an extra blank line in the Javadoc comment that should be
removed for consistency with standard Javadoc formatting.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
