peterxcli commented on code in PR #9118:
URL: https://github.com/apache/ozone/pull/9118#discussion_r2426457968
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/QuasiClosedStuckUnderReplicationHandler.java:
##########
@@ -124,7 +127,8 @@ public int processAndSendCommands(Set<ContainerReplica>
replicas, List<Container
if (firstException != null || totalCommandsSent < totalRequiredReplicas) {
// Some commands were not sent as expected (not enough nodes found or
overloaded nodes), so we just rethrow
// the first exception we encountered.
- LOG.info("A command was not sent for all required new replicas for
container {}. Total sent {}, required {} ",
+ LOG.info(
Review Comment:
could you please revert this unrelated change? Thanks!
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java:
##########
@@ -73,14 +73,14 @@
* the node state change should happen only via NodeStateManager. It also
* runs a heartbeat thread which periodically updates the node state.
* <p>
- * The getNode(byState) functions make copy of node maps and then creates a
list
- * based on that. It should be assumed that these get functions always report
- * *stale* information. For example, getting the deadNodeCount followed by
- * getNodes(DEAD) could very well produce totally different count. Also
- * getNodeCount(HEALTHY) + getNodeCount(DEAD) + getNodeCode(STALE), is not
- * guaranteed to add up to the total nodes that we know off. Please treat all
- * get functions in this file as a snap-shot of information that is
inconsistent
- * as soon as you read it.
+ * The getNode(byState) functions copy the node maps and then create a list
Review Comment:
could you please revert this unrelated change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
