[ 
https://issues.apache.org/jira/browse/HDDS-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046576#comment-18046576
 ] 

Chen-Jheng Sing commented on HDDS-14170:
----------------------------------------

[~adoroszlai] ,

Work on HDDS-14169 and HDDS-14170 is nearing completion.

I’m still working through some remaining CI unit test failures.

> No need to copy BucketEncryptionKeyInfo and DefaultReplicationConfig
> --------------------------------------------------------------------
>
>                 Key: HDDS-14170
>                 URL: https://issues.apache.org/jira/browse/HDDS-14170
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: common
>            Reporter: Attila Doroszlai
>            Assignee: Chen-Jheng Sing
>            Priority: Major
>              Labels: GoodForNewContributors
>
> {{OmBucketInfo#copyObject}} unnecessarily creates copies of 
> {{BucketEncryptionKeyInfo}} and {{DefaultReplicationConfig}}, neither of 
> which has any mutable state.
> - Simplify {{OmBucketInfo#copyObject}} implementation as 
> {{toBuilder().build()}}
> - Delete {{copy()}} in both classes
> - Annotate {{BucketEncryptionKeyInfo}} as {{@Immutable}}
> - Implement {{equals()}} and {{hashCode()}} in {{BucketEncryptionKeyInfo}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to