adoroszlai commented on a change in pull request #2254:
URL: https://github.com/apache/ozone/pull/2254#discussion_r635424895
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
##########
@@ -490,7 +527,23 @@ public static ContainerCommandRequestProto
getDeleteBlockRequest(
request.setContainerID(blockID.getContainerID());
request.setDeleteBlock(delRequest);
request.setDatanodeUuid(pipeline.getFirstNode().getUuidString());
- return request.build();
+ return request;
+ }
+
+ public static Builder newGetCommittedBlockLengthBuilder(Pipeline pipeline,
Review comment:
These return a builder, which the caller can further change. The goal
is to avoid proliferation of methods (with/without token, etc.). I haven't
converted all existing methods to return builder only to minimize the patch.
Can do it in a follow-up refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
