echonesis commented on PR #9689: URL: https://github.com/apache/ozone/pull/9689#issuecomment-3850674716
> > In initializeRatis() (StorageContainerManager.java L1354-L1358), I added explicit creation of snapshotDir: > > Sorry, I mean to ask -- When is the snapshotDir created for upgrade before this change? Before this change, both directories were auto-created in SCMSnapshotProvider constructor ([L71, L74-75](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMSnapshotProvider.java#L71-L75)) via `HddsUtils.createDir()`. So for upgrade, when `SCMHAManagerImpl` creates `SCMSnapshotProvider`, it auto-creates both directories there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
