szetszwo commented on code in PR #9689:
URL: https://github.com/apache/ozone/pull/9689#discussion_r2755599398
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java:
##########
@@ -95,10 +95,31 @@ public SCMHAManagerImpl(final ConfigurationSource conf,
}
@VisibleForTesting
- protected SCMSnapshotProvider newScmSnapshotProvider(StorageContainerManager
storageContainerManager) {
- return new SCMSnapshotProvider(storageContainerManager.getConfiguration(),
+ protected SCMSnapshotProvider newScmSnapshotProvider(
+ StorageContainerManager storageContainerManager) {
Review Comment:
This method is not used in test. Let's remove @ VisibleForTesting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
