devabhishekpal commented on code in PR #9867:
URL: https://github.com/apache/ozone/pull/9867#discussion_r2887919499
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1726,6 +1730,19 @@ message PartKeyInfo {
required KeyInfo partKeyInfo = 3;
}
+message MultipartPartInfo {
+ required string partName = 1;
+ required uint32 partNumber = 2;
+ repeated KeyLocationList keyLocationList = 6;
+ required uint64 dataSize = 7;
+ required uint64 modificationTime = 8;
+ required uint64 objectID = 9;
+ required uint64 updateID = 10;
Review Comment:
We can declare objectID, updateID as optional.
In the existing code flow these are not being consumed as such but they are
always populated when creating OmMultipartPartInfo from OmKeyInfo.
I think keeping them as required is better because:
- prevents silent default 0 values if omitted,
- keeps the version semantics
- and also it stays in line with how currently these fields are being
updated.
@adoroszlai if you think it might be better to keep these as optional as we
do not explicitly consume this in complete/abort I am okay with doing that as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
