adoroszlai commented on code in PR #9867: URL: https://github.com/apache/ozone/pull/9867#discussion_r2888410183
########## hadoop-ozone/interface-storage/src/main/proto/OmStorageProtocol.proto: ########## @@ -30,6 +30,7 @@ option java_generate_equals_and_hash = true; package hadoop.ozone; import "hdds.proto"; +import "OmClientProtocol.proto"; Review Comment: I don't think we can import `OmClientProtocol` as is [due to](https://github.com/apache/ozone/actions/runs/22707097294/job/65836276038?pr=9867#step:13:3616): ``` OmStorageProtocol.proto:49:25: "hadoop.ozone.OzoneAclInfo.type" is already defined in file "OmClientProtocol.proto" ``` Project for separation of storage and client protocol was started few years ago, but not completed. We need to copy any message definition being used (and improve them in the process if possible). Since we are adding new type for OM DB, ideally it should go in storage definition. However, this may turn out to be a big change, and I don't mean to delay the MPU improvement for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
