ChenSammi commented on code in PR #9858:
URL: https://github.com/apache/ozone/pull/9858#discussion_r2894455571
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeChoosingPolicyFactory.java:
##########
@@ -48,9 +48,9 @@ public static VolumeChoosingPolicy
getPolicy(ConfigurationSource conf) {
return ReflectionUtils.newInstance(policyClass, new Class<?>[]
{ReentrantLock.class}, LOCK);
}
- public static DiskBalancerVolumeChoosingPolicy
getDiskBalancerPolicy(ConfigurationSource conf) {
- Class<?> policyClass =
conf.getObject(DiskBalancerConfiguration.class).getVolumeChoosingPolicyClass();
- return (DiskBalancerVolumeChoosingPolicy) ReflectionUtils.newInstance(
+ public static VolumeContainerChoosingPolicy
getDiskBalancerContainerPolicy(ConfigurationSource conf) {
Review Comment:
We need a new dedicated Factory for ContainerChoosingPolicy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
