ChenSammi commented on code in PR #9858:
URL: https://github.com/apache/ozone/pull/9858#discussion_r2894459600
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/policy/DiskBalancerVolumeContainerCandidate.java:
##########
@@ -17,24 +17,34 @@
package org.apache.hadoop.ozone.container.diskbalancer.policy;
-import java.util.Map;
-import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.ozone.container.common.impl.ContainerData;
import org.apache.hadoop.ozone.container.common.volume.HddsVolume;
-import org.apache.hadoop.ozone.container.common.volume.MutableVolumeSet;
/**
- * This interface specifies the policy for choosing volumes to balance.
+ * Result of consolidated volume and container selection for disk balancing.
+ * Contains the container to move and its source and destination volumes.
*/
-public interface DiskBalancerVolumeChoosingPolicy {
- /**
- * Choose a pair of volumes for balancing.
- *
- * @param volumeSet - volumes to choose from.
- * @param thresholdPercentage the threshold percentage in range (0, 100) to
choose the source volume.
- * @param deltaSizes - the sizes changes of inProgress balancing jobs.
- * @param containerSize - the estimated size of container to be moved.
- * @return Source volume and Dest volume.
- */
- Pair<HddsVolume, HddsVolume> chooseVolume(MutableVolumeSet volumeSet,
- double thresholdPercentage, Map<HddsVolume, Long> deltaSizes, long
containerSize);
+public final class DiskBalancerVolumeContainerCandidate {
Review Comment:
Let's call it ContainerCandidate, instead of
DiskBalancerVolumeContainerCandidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
