sodonnel commented on code in PR #9829:
URL: https://github.com/apache/ozone/pull/9829#discussion_r2932440873
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/QuasiClosedStuckReplicaCount.java:
##########
@@ -147,25 +199,24 @@ public boolean isOverReplicated() {
}
public List<MisReplicatedOrigin> getOverReplicatedOrigins() {
- // If there is only a single origin, we expect 3 copies, otherwise we
expect 2 copies of each origin
+ // If there is only a single origin, we expect bestOriginCopies copies.
if (replicasByOrigin.size() == 1) {
final DatanodeID origin = replicasByOrigin.keySet().iterator().next();
final Set<ContainerReplica> inService = getInService(origin);
- if (inService.size() > 3) {
- return Collections.singletonList(new MisReplicatedOrigin(inService,
inService.size() - 3));
+ if (inService.size() > bestOriginCopies) {
Review Comment:
Same comment as above. I am not sure we want to change this bit for the "one
origin available" case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
