aswinshakil commented on code in PR #9829:
URL: https://github.com/apache/ozone/pull/9829#discussion_r2961574714
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/QuasiClosedStuckReplicaCount.java:
##########
@@ -106,28 +157,29 @@ public List<MisReplicatedOrigin>
getUnderReplicatedReplicas() {
misReplicatedOrigins.add(new MisReplicatedOrigin(entry.getValue(),
additionalReplicas));
}
} else {
- if (inService.size() < 3) {
- int additionalReplicas = 3 - inService.size();
+ if (inService.size() < bestOriginCopies) {
Review Comment:
By default it is 3, But what if we want to have more like 4 or 5? The main
patch is trying to make this configurable. Maybe I can make the configuration
to have minimum `bestOriginCopies` value as 3. If someone wants more copies
they can have it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
