adoroszlai commented on code in PR #10028:
URL: https://github.com/apache/ozone/pull/10028#discussion_r3027620172
##########
hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/load.sh:
##########
@@ -27,6 +27,6 @@ export COMPOSE_FILE="$TEST_DIR/compose/ha/docker-compose.yaml"
export OM_SERVICE_ID=omservice
export SECURITY_ENABLED="true"
-create_data_dirs dn{1..5} kms om{1..3} recon s3g scm{1..3}
+create_data_dirs dn{1..5} kms om{1..3} recon s3g s3g{1..3} scm{1..3}
Review Comment:
nit: `s3g` data dir is no longer used, but it's harmless, no need to update
patch just for this.
##########
hadoop-ozone/dist/src/main/compose/testlib.sh:
##########
@@ -278,7 +278,7 @@ reorder_om_nodes() {
"if [[ -f /etc/hadoop/ozone-site.xml ]]; then \
sed -i -e 's/om1,om2,om3/${new_order}/' /etc/hadoop/ozone-site.xml; \
echo 'Replaced OM order with ${new_order} in ${c}'; \
- fi"
+ fi" || true
Review Comment:
> silently swallow genuine bash failures
This is fine. In the worst case OM client will contact follower first with
the original order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]